Problem: We have no tests and we must scream. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hintjens
added a commit
that referenced
this pull request
Oct 9, 2015
Problem: We have no tests and we must scream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR adds a dependency on goczmq. It uses a goczmq Pull socket in the test. When we have a pure go implementation of Channeler that can pass this test by connecting to a goczmq Pull socket and sending a valid message, we'll have passed a hurdle.
Note that I chose Push / Pull for this first test because they are very simple sockets. Client / Server sockets have the additional overhead of handling client ids. Pub / Sub sockets have the added complexity of dealing with subscription messages. So, let's get a simple unidirectional message between a pure go Push and a goczmq Pull working first.