-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WITH_LIBSODIUM_STATIC option doesn't fully link libsodium statically #4484
Comments
it's up to the caller to use the appropriate compiler flags for these niche use cases |
@bluca This is not a niche use case, it is a bug in CMake. The current CMake file is not doing what it promised to do. |
Maybe https://github.com/jedisct1/libsodium/blob/stable/contrib/Findsodium.cmake |
@zeromq/core could someone reopen this issue? It is blocking for ZeromqJS. VsCode (used by millions) has been using the old version of zermqjs because of this. |
I
If this is a working fix can someone create a PR? |
@bluca Would you mind reopening this please? See these comments above: |
I've reopened it but as long as nobody comes up with a PR it is to no avail? |
Made #4562 to fix this issue. |
Issue description
In Zeromq.js, the libsodium is built statically, but the built library still tries to link to the dynamic libraries. I expect the built binary to include llibsodium and not rely on its dynamic libraries.
See zeromq/zeromq.js#529 (comment)
Environment
Minimal test code / Steps to reproduce the issue
pnpm install
What's the actual result? (include assertion message & call stack if applicable)
What's the expected result?
The built binary should not need the dynamic libraries
The text was updated successfully, but these errors were encountered: