Problems: test failures on PPC and GNU/hurd #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: detect cacheline size for aligment purposes at build time instead of hard-coding it, so that PPC and S390 can align to a value greater than the 64 bytes default. Uses libc getconf program, and falls back to the previous value of 64 if not found.
Solution: import macro from autoconf-archive that works better than AC_CHECK_FUNCS
Solution: prefer CXX11 atomics if they are available to compiler intrinsics. test_hwm_pubsub fails 50% of the times on PPC64 and RISC-V with an apparent memory corruption of messages sent by the application thread to the I/O thread when using compiler intrinsics. Switching to CXX11 atomics makes the test reliable again. The standard API should be preferred anyway, if available.
Solution: mark it as XFAIL like the other tests that use ipc://*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions: fix posix_memalign detection, improve cache alignment for yqueue, prefer CXX11 atomics to compiler intrinsics, add wildcard test to XFAIL