UDP engine aborts on networking-related errors from socket syscalls (2) #2862 #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluca
reviewed
Aug 25, 2019
src/ip.cpp
Outdated
| || errno == EINTR || errno == ETIMEDOUT || errno == EHOSTUNREACH | ||
| || errno == ENETUNREACH || errno == ENETDOWN || errno == ENETRESET | ||
| || errno == EINVAL || errno == EADDRINUSE || errno == EACCES | ||
| || errno == EWOULDBLOCK || errno == EAGAIN || errno == EPIPE); |
There was a problem hiding this comment.
Please do not add new errors mixed in with refactoring. It needs to be carefully weighted and tested to avoid introducing deadlocks.
There was a problem hiding this comment.
Ok, sure! So did unittest_poller keep running because I made some errors non-critical?
There was a problem hiding this comment.
Not sure - should be investigated
…eromq#2862 (revert changes in error list in zmq::assert_success_or_recoverable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for UDP send/receive. Also updated
plugfunction to terminate session only whensetsockoptfailed, and request reconnection otherwise. Still haven't looked into how socket monitoring events work, so error handling happens silently.Note that I added EAGAIN/EWOULDBLOCK and EPIPE in the list of "recoverable" errors.