Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level license files #1832

Closed
wants to merge 2 commits into from
Closed

Conversation

dcsaba89
Copy link
Contributor

@dcsaba89 dcsaba89 commented Feb 2, 2023

No description provided.

@minrk
Copy link
Member

minrk commented Feb 3, 2023

these files are already in the top-level of the repo as COPYING.BSD, COPYING.LESSER

@minrk minrk closed this Feb 3, 2023
@dcsaba89
Copy link
Contributor Author

dcsaba89 commented Feb 3, 2023

Hi @minrk, that file could not be recognized as a license file and causing issues for us, that is why I commited a new license file based on the following guide:
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

Please take a look at other repositories, the license file is in the root of the repository and called LICENSE or maybe LICENSE.txt

https://github.com/pandas-dev/pandas/blob/main/LICENSE
https://github.com/numpy/numpy/blob/main/LICENSE.txt
https://github.com/ipython/ipython/blob/main/LICENSE
https://github.com/jupyter/nbclassic/blob/main/LICENSE
https://github.com/jupyter-widgets/ipywidgets/blob/main/LICENSE

And you can see a badge on the top of the pages that shows the license itself and the associated permissions, limitations and conditions as well.

However you cannot see the same badge for your top level license files
https://github.com/zeromq/pyzmq/blob/main/COPYING.BSD
https://github.com/zeromq/pyzmq/blob/main/COPYING.LESSER

This change would help significantly to update pyzmq more frequently for our python projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants