Problem: zyre_peer_connect using bad endpoint #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to confusion in design, node was sometimes announcing internal endpoint like "tcp://*:12345" for public use in HELLO, causing failure in zyre_peer_connect (). Solution: remove confusing API options, require that zyre_set_endpoint provide an endpoint valid both for bind and for connect, and announce the correct endpoint in HELLO messages.
Solution: fixed test of zpoller return value on timeout.
sappo
added a commit
that referenced
this pull request
Aug 20, 2014
Problem: zyre_peer_connect using bad endpoint
|
Nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to confusion in design, node was sometimes announcing internal endpoint
like "tcp://*:12345" for public use in HELLO, causing failure in
zyre_peer_connect ().
Solution: remove confusing API options, require that zyre_set_endpoint
provide an endpoint valid both for bind and for connect, and announce the
correct endpoint in HELLO messages.