Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: zyre_peer_connect using bad endpoint #228

Merged
merged 3 commits into from
Aug 20, 2014
Merged

Conversation

hintjens
Copy link
Member

Due to confusion in design, node was sometimes announcing internal endpoint
like "tcp://*:12345" for public use in HELLO, causing failure in
zyre_peer_connect ().

Solution: remove confusing API options, require that zyre_set_endpoint
provide an endpoint valid both for bind and for connect, and announce the
correct endpoint in HELLO messages.

Due to confusion in design, node was sometimes announcing internal endpoint
like "tcp://*:12345" for public use in HELLO, causing failure in
zyre_peer_connect ().

Solution: remove confusing API options, require that zyre_set_endpoint
provide an endpoint valid both for bind and for connect, and announce the
correct endpoint in HELLO messages.
sappo added a commit that referenced this pull request Aug 20, 2014
Problem: zyre_peer_connect using bad endpoint
@sappo sappo merged commit 0268ec8 into zeromq:master Aug 20, 2014
@sappo
Copy link
Member

sappo commented Aug 20, 2014

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants