Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support npm scripts for windows developers #14

Merged
merged 4 commits into from
May 30, 2017
Merged

Conversation

dy93
Copy link
Contributor

@dy93 dy93 commented May 22, 2017

  1. use shx (Shelljs wrapper) to support unix command on windows.
  2. use better-npm-run to support environment variables on windows.
  3. not yet support npm run zip on windows

dy93 added 2 commits May 23, 2017 01:40
1. use shx (Shelljs wrapper) to support unix command on windows.
2. use better-npm-run to support environment variables on windows.
3. not yet support `npm run zip` on windows
@dy93
Copy link
Contributor Author

dy93 commented May 23, 2017

稍微改了一下 npm scripts,讓 windows 也可以順利開發

@zeroshine
Copy link
Owner

zip 可能也要改一下

use bestzip module to support zip command on windows
@dy93
Copy link
Contributor Author

dy93 commented May 29, 2017

改用 bestszip 來提供跨平台的 zip 指令
有在 ubuntu 上測試過行為跟原本是一致的
雖然我沒有 mac os 的機器可以測試,但是期望行為應該也是一致的

@zeroshine zeroshine merged commit b7c46f2 into zeroshine:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants