Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bilayer again #186

Closed
wants to merge 4 commits into from
Closed

Bilayer again #186

wants to merge 4 commits into from

Conversation

tfrederiksen
Copy link
Contributor

Some further polishing:

  • keep the rotation axis in the middle of the cell (generates visually more intuitive structures in my opinion)
  • make layers of identical atom types if only one layer (but either of them) is provided
  • added BA stacking (different from AB for stacked heterolayers)

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #186 into master will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   85.19%   85.18%   -0.01%     
==========================================
  Files         120      120              
  Lines       19075    19079       +4     
==========================================
+ Hits        16251    16253       +2     
- Misses       2824     2826       +2     
Impacted Files Coverage Δ
sisl/geom/bilayer.py 93.54% <80.00%> (-3.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e605a26...0e7b5c8. Read the comment docs.

sisl/geom/bilayer.py Show resolved Hide resolved
@zerothi
Copy link
Owner

zerothi commented Mar 28, 2020

This is now merged! Thanks!

@zerothi zerothi closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants