Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use log in vach-cli #68

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Use log in vach-cli #68

merged 1 commit into from
Feb 6, 2022

Conversation

zeskeertwee
Copy link
Owner

This replaces (most) println!'s with log calls on appropriate levels and initializes pretty_env_logger in the cli.

solves #47

@sokorototo
Copy link
Collaborator

Does this logger interfere with the progress bar?

@sokorototo
Copy link
Collaborator

I have a 4 hour long electronics class, will review when back

@zeskeertwee
Copy link
Owner Author

Does this logger interfere with the progress bar?

No, it still println!'s there

sokorototo
sokorototo approved these changes Feb 6, 2022
View reviewed changes
Copy link
Collaborator

@sokorototo sokorototo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, sorry for the wait was at my parents

@sokorototo sokorototo merged commit a84c004 into main Feb 6, 2022
@sokorototo sokorototo deleted the vach-cli-env-log branch February 6, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokorototo sokorototo sokorototo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeskeertwee @sokorototo