-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 (oui, encore) #4673
Merged
artragis
merged 5 commits into
zestedesavoir:dev
from
motet-a:quand-passe-t-on-a-python-4
Sep 28, 2017
Merged
Python 3 (oui, encore) #4673
artragis
merged 5 commits into
zestedesavoir:dev
from
motet-a:quand-passe-t-on-a-python-4
Sep 28, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motet-a
force-pushed
the
quand-passe-t-on-a-python-4
branch
2 times, most recently
from
September 27, 2017 08:05
34374d0
to
085e5c9
Compare
Ne nous embêtons pas avec flake8 pendant la migration vers Python 3. Ces changements sont temporaires et doivent être annulés dès que possible.
Passe 2to3 sur Travis pour la migration vers Python 3. Ce commit doit être revert.
motet-a
force-pushed
the
quand-passe-t-on-a-python-4
branch
from
September 27, 2017 16:34
085e5c9
to
d5390de
Compare
Ce commit rassemble les choses qui ne peuvent pas être faites automatiquement par `2to3`. Ce commit contient presque entrièrement du travail fait par pierre_24, merci à lui !
Ce commit a été fait automatiquement par 2to3.
This reverts commit e0582f7.
motet-a
force-pushed
the
quand-passe-t-on-a-python-4
branch
from
September 27, 2017 17:09
ba2539b
to
15d0478
Compare
4 tasks
Yeah, bravo ! |
Bravo, les copains ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entièrement basé sur le travail de @pierre-24, merci à lui !
Donc, le principe est d’automatiser ce qui est automatisable avec
2to3
, comme ça pas de conflits, on peut rebase autant qu’on veut et c’est beaucoup plus facile à relire : il n’y a que le commit “Préparatifs” à vraiment relire. Le commit “2to3” est normalement inintéressant.Cette PR désactive flake8 dans le
.travis.yml
, c’était trop compliqué à gérer d’un coup. Mais ce n’est pas bien grave, il faut juste refaire rapidement une autre PR qui corrige les quelques erreurs de style restantes et réactive flake8.