Colored Spans #97
Closed
Colored Spans #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder whether labels without a message should just default to this behaviour? That would seem sensible to me. What do you think? |
|
I thought of that at first, but went this way because I like the intentionality behind it, but if you think empty labels would be better I am happy to rework this PR |
|
I think that's probably preferable over adding another corner of the API. I highly doubt that "empty label that occupies space for no reason" is a desirable thing, so we might as well use that case for this. |
|
Oh... why was this closed? |
|
Doing this via labels was going to need more work than I want to put into it right now, and I am no longer using ariadne in my project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds colored spans that take priority over labels. Useful for showing correlation with suggestions / help text. Implements my issue in #96
Without the PR, using empty labels that result in a bunch of whitespace.