-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to create tar.gz files. #76
Comments
The current option forces setuptools to generate a zipfile. I guess that's not really needed anymore. So... instead of adding a tar option, I'd rather say "we don't need to pass the zip option anymore". Setuptools will then use some default, which is probably tgz files. @mauritsvanrees: tgz is probably fine now? |
Probably okay. I started writing that we should still check for the Python version: if it is 2.4.x we should still use zip. But looking at our setup.py we only support Python 2.6 and 2.7. So should be okay to remove our zip default. There is a nagging doubt in the back of my mind, because I had some problems recently with a tarball that I created on my Mac and that could not be extracted on some Linux server. Problem was that I was using the Mac standard Long story short: should be okay. :-) BTW, I think whether zip or targz or something else is used by default depends on the OS. Indeed, see https://docs.python.org/2/distutils/sourcedist.html. If you want to override the default behavior you can add a
|
Hm... I am getting all sorts of hard-to-debug doctest failures. The common problem. |
Is this related to tgz files? |
Yep, the expected sometimes-I-fail-sometimes-I-dont related to 'tags dir does not exist' where we try to answer 'no, do not create it' first, and it creates it anyway. Something like that. |
Ok, tests are OK again. Released as 3.56 and.... it is a tgz automatically :-) |
@yesimon: the 'Yep' was for Reinout. As answer to you: No, the doctest failures are not related to tgz files, they have been here for a while, sometimes failing sometimes not.... :-( See https://travis-ci.org/zestsoftware/zest.releaser/builds/54873008 |
I see in this line that maybe python 2.4 has some issues with creating tar.gz files
zest.releaser/zest/releaser/release.py
Line 105 in 08bde24
However since that's a really old python by now, can we add an option to upload tar files to pypi?
The text was updated successfully, but these errors were encountered: