Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zesty init updates on instance create to use instance-installer #123

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Zesty init updates on instance create to use instance-installer #123

wants to merge 4 commits into from

Conversation

mattezra
Copy link
Contributor

No description provided.

@mattezra mattezra marked this pull request as draft April 28, 2023 09:58
@mattezra mattezra marked this pull request as ready for review May 2, 2023 08:34
@mattezra mattezra requested a review from shrunyan May 2, 2023 08:34
@mattezra
Copy link
Contributor Author

mattezra commented May 2, 2023

cli changes for nextjs-starter fixes:

  1. added media_domain/s of an instance in .zesty/config.json
  2. replaced blueprint installation with instance-installer on zesty instance create using nextjs-marketing template

@mattezra mattezra self-assigned this May 2, 2023
@shrunyan
Copy link
Contributor

shrunyan commented May 3, 2023

Please split this PR up. These need too be discrete changes.

agalin920
agalin920 suggested changes May 3, 2023
View reviewed changes
src/commands/init.ts Outdated
mediaDomains.push(bin.cdn_base_url)
});

instance["mediaDomain"] = mediaDomains
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this name the key in the config "mediaDomain"? Can we change it to "mediaDomains" to convey its an array

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data should not be part of this file. See #123 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this change in this PR.

@shrunyan
Copy link
Contributor

shrunyan commented May 3, 2023

The media requests should not be added too this command.

Init only serves the purpose of orchestrating initial account creation/signin, instance creation/selection.

The .zesty/ directory is intended as a place for storing instance and project data. Going forward, any API entities we want persisted within a projects file structure should receive it's own [ENTITY].json file. Following this pattern the config.json file is going to be renamed instance.json. Meaning a bin entity is not appropriate to be written to an instance file.

@mattezra mattezra changed the title Zesty init updates on instance create and config file created Zesty init updates on instance create to use instance-installer May 3, 2023
@mattezra
Copy link
Contributor Author

mattezra commented May 3, 2023

@shrunyan

This PR only contains the change in zesty instance create where instead of blueprint installation, template installation is already being used.

@mattezra mattezra requested a review from allenpigar May 8, 2023 22:31
@shrunyan shrunyan mentioned this pull request May 17, 2023
Merged
@mattezra mattezra added enhancement New feature or request ready labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalin920 agalin920 agalin920 requested changes

@shrunyan shrunyan Awaiting requested review from shrunyan

@allenpigar allenpigar Awaiting requested review from allenpigar

At least 1 approving review is required to merge this pull request.

Assignees

@mattezra mattezra

Labels
enhancement New feature or request ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattezra @shrunyan @agalin920