Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish button still shows up even if publish is set to false #2811

Closed
Eerkz opened this issue Jul 15, 2024 · 6 comments · Fixed by #2899
Closed

Publish button still shows up even if publish is set to false #2811

Eerkz opened this issue Jul 15, 2024 · 6 comments · Fixed by #2899
Assignees

Comments

@Eerkz
Copy link

Eerkz commented Jul 15, 2024

Describe the bug
Having a custom role with a granural role for a content item that has publish:false still shows the publish button on the content item ui.

To Reproduce
Steps to reproduce the behavior:

  1. Create a custom role.
  2. Attach a granural role to the custom role with a content-item zuid as the resourceZUID and set the permissions to:
 {
   "create": true,
    "read": true,
    "update": true,
    "delete": false,
    "publish": false,
    "grant": false
 }
  1. View the content item in (2) the manager-ui, the publish button will still be shown.

Expected behavior
When publish is set to false for the content item granural role, the publish button should be hidden for the content item

Screenshots
Screenshot 2024-07-15 at 11 01 52 PM

Additional Context
Instance zuid: 8-c28bb580b8-8xl3n4
Custom Role: 30-f6b2e9f7e4-s4vnfd
Granural Role Zuid: 32-8c99a18da3-20x3ms

@giseleblair
Copy link
Contributor

@Eerkz can you please share screenshots of the UI response when this user role clicks the publish button

@giseleblair
Copy link
Contributor

@Eerkz Also, what is the system role assigned to the custom role?

@Eerkz
Copy link
Author

Eerkz commented Jul 15, 2024

@Eerkz can you please share screenshots of the UI response when this user role clicks the publish button

Hi @giseleblair . Nothing changes when the publish button is clicked. The publish button just shows the loading icon and then it stops and then nothing after, UI stays the same before the button is clicked

@Eerkz
Copy link
Author

Eerkz commented Jul 15, 2024

@Eerkz Also, what is the system role assigned to the custom role?

The developer system role

@giseleblair
Copy link
Contributor

@Eerkz Also, what is the system role assigned to the custom role?

The developer system role

@Eerkz is this because the user role needs to still be able to publish across all other content items?

@Eerkz
Copy link
Author

Eerkz commented Jul 15, 2024

@Eerkz Also, what is the system role assigned to the custom role?

The developer system role

@Eerkz is this because the user role needs to still be able to publish across all other content items?

@giseleblair it was based off the developer role so that the user could access the "apps" that the developer role has access to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants