-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/2430 create model modal #2535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agalin920 I had to upate the test case, to wait for a couple of seconds seems like the parent model dropdown options is taking time to populate during testing.
Also this issues exist even before this update, it's just that previously when you hit enter even there's no option it doesn't do aynthing. so test can proceed.
This time it fails because if there's no options available, when enter key is hit it submitted the form, causing the create modal click button to fail.
Screen.Recording.2024-02-06.at.12.39.42.PM.mov |
Would expect tests to pass. Feel free to re run the action if there is a flaky test |
@agalin920 I updated the test to wait for nav data before proceeding, looks like it's working locally, however test doesn't seem to work with Gh actions, is there's anything i should consider? Screen.Recording.2024-02-07.at.10.29.13.AM.mov |
@jomarmontuya if it works locally but on on the pipeline it might mean the solution is still not robust enough and does not work in slower environments. You can download the screenshots from the ci pipeline to gain more insight into what is failing |
@agalin920 Looks like it's passing now There are still failing flaky test but not related to this PR, should i look into those as well or this should be good for now? |
@jomarmontuya updated tests to not break the others |
closes #2430
Screen.Recording.2024-02-05.at.9.41.37.AM.mov