Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2430 create model modal #2535

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Fix/2430 create model modal #2535

merged 8 commits into from
Feb 15, 2024

Conversation

jomarmontuya
Copy link
Contributor

@jomarmontuya jomarmontuya commented Feb 6, 2024

closes #2430

Screen.Recording.2024-02-05.at.9.41.37.AM.mov

Copy link
Contributor Author

@jomarmontuya jomarmontuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agalin920 I had to upate the test case, to wait for a couple of seconds seems like the parent model dropdown options is taking time to populate during testing.

Also this issues exist even before this update, it's just that previously when you hit enter even there's no option it doesn't do aynthing. so test can proceed.

This time it fails because if there's no options available, when enter key is hit it submitted the form, causing the create modal click button to fail.

@jomarmontuya
Copy link
Contributor Author

Screen.Recording.2024-02-06.at.12.39.42.PM.mov

@agalin920
Copy link
Contributor

Would expect tests to pass. Feel free to re run the action if there is a flaky test

cypress/e2e/schema/models.spec.js Outdated Show resolved Hide resolved
@jomarmontuya
Copy link
Contributor Author

@agalin920 I updated the test to wait for nav data before proceeding, looks like it's working locally, however test doesn't seem to work with Gh actions, is there's anything i should consider?

Screen.Recording.2024-02-07.at.10.29.13.AM.mov

@jomarmontuya jomarmontuya self-assigned this Feb 7, 2024
@agalin920
Copy link
Contributor

@jomarmontuya if it works locally but on on the pipeline it might mean the solution is still not robust enough and does not work in slower environments. You can download the screenshots from the ci pipeline to gain more insight into what is failing

@jomarmontuya jomarmontuya added blocked bug Something isn't working labels Feb 7, 2024
@jomarmontuya jomarmontuya marked this pull request as draft February 7, 2024 07:45
@jomarmontuya jomarmontuya added ready PR is complete and ready for deployment and removed blocked labels Feb 8, 2024
@jomarmontuya
Copy link
Contributor Author

jomarmontuya commented Feb 8, 2024

@agalin920 Looks like it's passing now

There are still failing flaky test but not related to this PR, should i look into those as well or this should be good for now?

@jomarmontuya jomarmontuya marked this pull request as ready for review February 8, 2024 07:43
@agalin920
Copy link
Contributor

@jomarmontuya updated tests to not break the others

@zcolah zcolah added the vqa VQA is complete and approved label Feb 15, 2024
@shrunyan shrunyan merged commit 7650a8a into master Feb 15, 2024
1 check passed
@shrunyan shrunyan deleted the fix/2430-create-model-modal branch February 15, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PR is complete and ready for deployment vqa VQA is complete and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema: Create Model Modal - Enter Key should trigger Create Model Button
4 participants