Fix/filter out doctype tags from legacy head tags #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnar-bin
approved these changes
May 22, 2024
…fined-reading-map
shrunyan
deleted the
2685-typeerror-cannot-read-properties-of-undefined-reading-map
branch
shrunyan
pushed a commit
that referenced
this pull request
May 31, 2024
doctype tag is typically ID: 1 so this filter was removing it properly. However there is an edge case that can include more doctype tags so a better solution is to filter them out by type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctype tag is typically ID: 1 so this filter was removing it properly. However there is an edge case that can include more doctype tags so a better solution is to filter them out by type