Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL when fetching gov proposals #396

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix URL when fetching gov proposals #396

merged 1 commit into from
Jul 29, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jul 22, 2024

Summary by CodeRabbit

  • New Features

    • Updated API endpoint URLs for fetching governance proposals on both testnet and mainnet.
  • Bug Fixes

    • Resolved issues related to outdated URLs for governance proposal retrieval, ensuring smoother access to relevant data.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 1:24pm

Copy link
Contributor

coderabbitai bot commented Jul 22, 2024

Walkthrough

The recent updates focus on modifying the API endpoint URLs in the GovUpgradeProposals component for both testnet and mainnet environments. The old URLs have been replaced with new ones that indicate a transition to a different infrastructure. This change does not alter the overall functionality of the component, ensuring continuity in accessing governance proposals while enhancing the system's robustness.

Changes

Files Change Summary
src/components/Docs/components/GovUpgradeProposals.tsx Updated testnet and mainnet API endpoint URLs for governance proposals to reflect new infrastructure without changing functionality.

Poem

🐰 In the meadow where data flows,
New paths for proposals now brightly glow.
With URLs refreshed, we leap with glee,
Governance awaits, come hop with me!
🥕✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
src/components/Docs/components/GovUpgradeProposals.tsx (1)

10-10: The new mainnet API URL is not functional.

The URL https://zetachain-mainnet.g.allthatnode.com/archive/rest/cosmos/gov/v1/proposals returned an HTTP 501 status code, indicating it is not implemented or not correctly set up. Please verify and correct the URL.

  • File: src/components/Docs/components/GovUpgradeProposals.tsx
  • Line: 10
Analysis chain

Verify the new mainnet API URL.

Ensure that the new mainnet API URL https://zetachain-mainnet.g.allthatnode.com/archive/rest/cosmos/gov/v1/proposals is correct and functional.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new mainnet API URL is correct and functional.

# Test: Fetch data from the new mainnet API URL. Expect: Successful response.
curl -I https://zetachain-mainnet.g.allthatnode.com/archive/rest/cosmos/gov/v1/proposals

Length of output: 915

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a44ffd9 and f55c203.

Files selected for processing (1)
  • src/components/Docs/components/GovUpgradeProposals.tsx (1 hunks)
Additional comments not posted (1)
src/components/Docs/components/GovUpgradeProposals.tsx (1)

9-9: Verify the new testnet API URL.

Ensure that the new testnet API URL https://zetachain-athens.g.allthatnode.com/archive/rest/cosmos/gov/v1/proposals is correct and functional.

@fadeev fadeev merged commit 4b65095 into main Jul 29, 2024
6 checks passed
@fadeev fadeev deleted the fix-gov-props branch July 29, 2024 13:55
@coderabbitai coderabbitai bot mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants