-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BTC deposit fee docs #452
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughWalkthroughThe changes involve the addition of a "Deposit Fee" section in the Bitcoin transaction documentation on ZetaChain, detailing the fee structure and calculation for Bitcoin deposits. Concurrently, the ZRC-20 documentation simplifies the explanation of Bitcoin deposit fees by removing detailed calculations and instead providing a reference to another section for further information. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
src/pages/developers/chains/bitcoin.mdx (2)
90-94
: Clarify the fee structure explanation.The explanation of the fee structure could be clearer. Consider rephrasing to explicitly state that the fee is shared between the depositor and the withdrawer, and that it is charged in advance as a deposit fee.
Consider rephrasing to:
-Unlike EVM-based chains, each deposited Bitcoin output incurs a fee when it is spent. To address this, both the depositor and the withdrawer share the cost of the spend. This fee is charged in advance as a deposit fee. +Unlike EVM-based chains, each deposited Bitcoin output incurs a fee when it is spent. To address this, the cost is shared between the depositor and the withdrawer. This fee is charged in advance as a deposit fee.
96-105
: Ensure the formula is clear and accurate.The formula and its explanation are clear, but consider adding more context to ensure accuracy and understanding. For example, explain why
68vB
is used and what it represents.Consider adding an explanation for
68vB
:-The Bitcoin deposit fee is calculated with the following formula: +The Bitcoin deposit fee is calculated using the following formula, where `68vB` represents the average size of a Bitcoin transaction input:
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/pages/developers/chains/bitcoin.mdx (1 hunks)
- src/pages/developers/tokens/zrc20.mdx (1 hunks)
Files skipped from review due to trivial changes (1)
- src/pages/developers/tokens/zrc20.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Update the BTC deposit formula to: zeta-chain/node#2765
Summary by CodeRabbit
New Features
Documentation