Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSS: proper p2pid and Keygen #88

Merged
merged 16 commits into from
Apr 14, 2022
Merged

TSS: proper p2pid and Keygen #88

merged 16 commits into from
Apr 14, 2022

Conversation

brewmaster012
Copy link
Collaborator

@brewmaster012 brewmaster012 commented Apr 6, 2022

closes #87


if (( $NODE_NUMBER == 0 )); then
yes | zetaclientd -val val 2>&1 | tee ~/.zetaclient/zetaclient.log
else
export SEED=172.24.0.220
yes | zetaclientd -val val \
--peer /dns/${NODE_0_DNS}/tcp/6668/p2p/16Uiu2HAmACG5DtqmQsHtXg4G2sLS65ttv84e7MrL4kapkjfmhxAp \
Copy link
Collaborator Author

@brewmaster012 brewmaster012 Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this address:
/dns/${NODE_0_DNS}/tcp/6668/p2p/16Uiu2HAmACG5DtqmQsHtXg4G2sLS65ttv84e7MrL4kapkjfmhxAp

is hardcoded now; need it to dynamically change according to http query zetaclient0:8123/p2p

@CharlieMc0

Copy link
Member

@CharlieMc0 CharlieMc0 Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean by dynamically change according to http query zetaclient0:8123/p2p. 172.24.0.220 and ${NODE_0_DNS} should always resolve to the same address. I wasn't sure if the $SEED Env Var could handle DNS names otherwise I would have used the same ${NODE_0_DNS} value for both.

It would be ideal if SEED could handle DNS names instead of just IPs. Using hostnames instead of IPs everywhere will give us and other validators more flexibility.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm refering to this part:
16Uiu2HAmACG5DtqmQsHtXg4G2sLS65ttv84e7MrL4kapkjfmhxAp

This is hardcoded now but will change when we use real validator key for the p2pid

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed in the build script but the new TSS Address still needs to be whitelisted by the MPI Contracts. Let me know when I can get the current TSS address from the http://localhost:1317/zeta-chain/zetacore/zetacore/tSS/Eth endpoint and I'll get it setup and working.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest commit d14db6c the TSS address will show up in that endpoint at around block 30.

CharlieMc0 and others added 7 commits April 7, 2022 20:29
At block 30 zetacore will collect pubkeys from NodeAccounts
and create a keygen command.

Zetaclient initiates Keygen ceremony upon seeing the keygen
command from zetacore.
Genesis test: at block 25 Keygen will initiate
Before block 30 the http://localhost:1317/zeta-chain/zetacore/zetacore/tSS
endpoint should report the newly generated TSS address & pubkey
@brewmaster012 brewmaster012 changed the title TSS: use validator key as p2pid and TSS privkey TSS: proper p2pid and Keygen Apr 13, 2022
CharlieMc0
CharlieMc0 previously approved these changes Apr 14, 2022
Copy link
Member

@CharlieMc0 CharlieMc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me when I run it locally.

Copy link
Member

@CharlieMc0 CharlieMc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the old build-docker workflow that isn't needed anymore. Everything else still looks good.

@brewmaster012 brewmaster012 merged commit 39b4006 into main Apr 14, 2022
@CharlieMc0 CharlieMc0 deleted the p2pid branch May 3, 2022 16:17
CharlieMc0 pushed a commit that referenced this pull request Jun 27, 2023
TSS: proper p2pid and Keygen
CharlieMc0 pushed a commit that referenced this pull request Jun 27, 2023
TSS: proper p2pid and Keygen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use validator key as zetaclient p2p key and TSS node party id
2 participants