-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSS: proper p2pid and Keygen #88
Conversation
build/zetaclient-start.sh
Outdated
|
||
if (( $NODE_NUMBER == 0 )); then | ||
yes | zetaclientd -val val 2>&1 | tee ~/.zetaclient/zetaclient.log | ||
else | ||
export SEED=172.24.0.220 | ||
yes | zetaclientd -val val \ | ||
--peer /dns/${NODE_0_DNS}/tcp/6668/p2p/16Uiu2HAmACG5DtqmQsHtXg4G2sLS65ttv84e7MrL4kapkjfmhxAp \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this address:
/dns/${NODE_0_DNS}/tcp/6668/p2p/16Uiu2HAmACG5DtqmQsHtXg4G2sLS65ttv84e7MrL4kapkjfmhxAp
is hardcoded now; need it to dynamically change according to http query zetaclient0:8123/p2p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean by dynamically change according to http query zetaclient0:8123/p2p
. 172.24.0.220 and ${NODE_0_DNS} should always resolve to the same address. I wasn't sure if the
It would be ideal if SEED could handle DNS names instead of just IPs. Using hostnames instead of IPs everywhere will give us and other validators more flexibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm refering to this part:
16Uiu2HAmACG5DtqmQsHtXg4G2sLS65ttv84e7MrL4kapkjfmhxAp
This is hardcoded now but will change when we use real validator key for the p2pid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed in the build script but the new TSS Address still needs to be whitelisted by the MPI Contracts. Let me know when I can get the current TSS address from the http://localhost:1317/zeta-chain/zetacore/zetacore/tSS/Eth endpoint and I'll get it setup and working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest commit d14db6c the TSS address will show up in that endpoint at around block 30.
At block 30 zetacore will collect pubkeys from NodeAccounts and create a keygen command. Zetaclient initiates Keygen ceremony upon seeing the keygen command from zetacore.
Genesis test: at block 25 Keygen will initiate Before block 30 the http://localhost:1317/zeta-chain/zetacore/zetacore/tSS endpoint should report the newly generated TSS address & pubkey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me when I run it locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the old build-docker workflow that isn't needed anymore. Everything else still looks good.
TSS: proper p2pid and Keygen
TSS: proper p2pid and Keygen
closes #87