Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1951/endless-spinner #1977

Merged
merged 1 commit into from
May 24, 2024
Merged

issue-1951/endless-spinner #1977

merged 1 commit into from
May 24, 2024

Conversation

kaulfield23
Copy link
Contributor

Description

This PR fixes endless spinner in calendar day view

Screenshots

Calendar.Mozilla.Firefox.2024-05-22.10-30-45.mp4

Changes

  • Adds false to isLoading, isStale. And set timestamp to loaded

Notes to reviewer

Related issues

Resolves #1951
Resolves #1968

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've looked at the code and tried the preview build and everything looks good to me. 💯

@kaulfield23 kaulfield23 merged commit 7aec3a3 into main May 24, 2024
5 checks passed
@kaulfield23 kaulfield23 deleted the issue-1951/endless-spinner branch May 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants