feat(production): loggability and error tolerance

fix(compat): adhere more to fastly behavior in canvas

Author: James Zetlen

package-lock.json

@@ -64,6 +64,7 @@
   "dependencies": {
     "accepts": "^1.3.7",
     "debug": "^4.1.1",
+    "mime": "^2.4.4",
     "mime-types": "^2.1.25",
     "on-headers": "^1.0.2",
     "vary": "^1.1.2"

package.json

@@ -1,28 +1,19 @@
-import { Param, Params } from './imageopto-types';
+import { IRequestErrors, Warning } from './imageopto-types';
 
-/**
- * @hidden
- */
-export class FastlyParamError extends Error {
-  constructor(params: Params, name: Param, customMessage?: string) {
-    let message = `"${name}" cannot be "${params.get(name)}"`;
-    if (customMessage) {
-      message += `: ${customMessage}`;
-    }
-    super(message);
-    Error.captureStackTrace(this, this.constructor);
+export default class RequestErrors implements IRequestErrors {
+  public url: string;
+  public warnings: Warning[];
+  constructor(url: string, warnings: Warning[]) {
+    this.url = url;
+    this.warnings = warnings;
   }
-}
-
-/**
- * @hidden
- */
-export class FastlyCompatError extends FastlyParamError {
-  constructor(params: Params, name: Param, feature: string) {
-    super(
-      params,
-      name,
-      `Fastly imageopto ${feature} unsupported by node-hastily`
-    );
+  public toJSON(): IRequestErrors {
+    return { url: this.url, warnings: this.warnings };
+  }
+  public toString(): string {
+    return `Processing "${this.url}" produced warnings:${this.warnings.map(
+      ({ type, msg }) => `\n  - [${type}]: ${msg}`
+    )}
+`;
   }
 }

src/lib/errors.ts

@@ -0,0 +1,58 @@
+import test from 'ava';
+import { mockParams } from './mappers/__testhelpers';
+
+test('quality getter works', t => {
+  const noQuality = mockParams('');
+  t.is(noQuality.quality, undefined, 'unset quality is undefined');
+  t.is(noQuality.quality, undefined, 'cached quality');
+  t.is(
+    mockParams('quality=nothing').quality,
+    undefined,
+    'NaN quality is undefined'
+  );
+  t.is(mockParams('quality=50').quality, 50, 'numeric quality is stored');
+});
+
+test('toTaggedValues honors positionals', t => {
+  t.deepEqual(
+    mockParams('canvas=a,b,ccee,ddee,feff,eeee').toTaggedValues(
+      'canvas',
+      ['ay', 'bee'],
+      ['c', 'd', 'e', 'f']
+    ),
+    {
+      ay: 'a',
+      bee: 'b',
+      c: 'cee',
+      d: 'dee',
+      e: 'eee',
+      f: 'eff'
+    }
+  );
+});
+
+test('toTaggedValues honors positionals 2 s', t => {
+  t.deepEqual(
+    mockParams('canvas=300,300,x90,y10').toTaggedValues(
+      'canvas',
+      ['width', 'height'],
+      ['x', 'y', 'smart', 'offset-x', 'offset-y']
+    ),
+    {
+      height: '300',
+      width: '300',
+      x: '90',
+      y: '10'
+    }
+  );
+});
+
+test('toTaggedValues does not put named params in positionals', t => {
+  t.throws(() =>
+    mockParams('canvas=400,gutter5').toTaggedValues(
+      'canvas',
+      ['width', 'height'],
+      ['gutter']
+    )
+  );
+});