Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plain NuGet Servers don’t have a register url, so the login dialog never closes #136

Closed
iadonkey opened this issue Jul 29, 2024 · 1 comment
Closed

Plain NuGet Servers don’t have a register url, so the login dialog never closes #136

iadonkey opened this issue Jul 29, 2024 · 1 comment

Comments

@iadonkey
Copy link
Contributor

See

Twinpack/TwinpackShared/Protocol/Authentication.cs

Line 50 in 264bb29

while (!_packageServer.LoggedIn)

RegisterUrl = null results in an endless loop unless login is successful
@iadonkey iadonkey mentioned this issue Jul 29, 2024
Closed
@iadonkey
Copy link
Contributor Author

Will be available in the next release (> 1.0.7)

iadonkey added a commit that referenced this issue Jul 29, 2024
@iadonkey
fix: dialog for login doesn't close for NuGet servers if login fails,…
a3a80f5 
… this closes #136

(cherry picked from commit bc214ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iadonkey