Get rid of jsmn dependency #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify parsing code and edge conditions, copy the string to a null terminated buffer. This means tensors_open now allocates (when successfull), but this reduces the overall footprint as we no longer need to pad the strings to 64 bytes.
We no longer need it as we use a custom JSON parser.
One of these requires a manual copy to int array but otherwise they are easily shareable. As a side-effect we will parse data_offsets with just one field, but that will fail to validate because end will be 0.
We don't really need json_string and json_key; also, parsing objects can be slightly more concise.
On second thought, we don't actually need to malloc here. COW mapping doesn't really seem to have an obvious downside that should make us reject its viability here.
For consistency, 's' is now called 'json' everywhere. Metadata parsing is now performed by parse_metadata function, which removes "nested" structure parsing from tensor_parse, making it cleaner.
We let the loop break on its own which saves a little bit of flow.
We no longer use jsmn :) CUDA is considered a platform dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually really only need ~75 lines to parse JSON ourselves, so let's go ahead and do that. This removes the last dependency from this code, apart from CUDA which we treat as a "platform" (similar to libc).