Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] string_view support #441

Closed
wants to merge 11 commits into from
Closed

[WIP] string_view support #441

wants to merge 11 commits into from

Conversation

halx99
Copy link

@halx99 halx99 commented Sep 29, 2021

Don't needs merge, just a idea

  • All string setter function use string_view_t
  • API compatible with 1.11.x, but binary incompatible.
  • Add explicit boolean type for store bool value as string value true, false and avoid compiler ambiguous match const char_t* as scalar type 'bool'
  • Add length field to support getter string as string_view_t, it's useful for avoid unnecessary strlen operations, could track this branch: https://github.com/halx99/pugixml/tree/dev

@brandl-muc
Copy link
Contributor

I think you would need to use basic_string_view<char_t> instead of string_view.

@halx99
Copy link
Author

halx99 commented Sep 29, 2021

Yes, will change later

@halx99
Copy link
Author

halx99 commented Dec 23, 2021

Close, replaced by the super newer: #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants