Replace factory in provider by something better

[bakura10]

My IDE (PHPStorm) complains about an abstract static function. It does not throw an error but says this is not a recommanded practice. I think we should follow ZF pattern and have a Factory class instead.

What do you think ?

[ghost]

What exactly are you referring to? I'm ashamed if I have an abstract static function somewhere...

[bakura10]

You had a static function in an interface, PHPStorm considered it as "abstract".

Either way, I'm also modified your code, I have removed your ProviderInterface and replaced it by making the AbstractProvider implementing the ListenerAggregateInterface from ZF 2.

[bakura10]

But we'd better have a Factory class, so we do Factory::factory($config) instead of the $class::factory($config). It looks cleaner to me.

[ghost]

+1

[jmleroux]

You had a static function in an interface, PHPStorm considered it as "abstract".

Maybe it's because the abstract class AbstractProvider implements ProviderInterface without providing factory implementation.
Indeed, a bit strange...

[bakura10]

Everything's been fixed by refactor.