Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify permission interface #1

Merged
merged 1 commit into from
Dec 14, 2013
Merged

Simplify permission interface #1

merged 1 commit into from
Dec 14, 2013

Conversation

bakura10
Copy link
Member

ping @arekkas @spiffyjr @danizord

I need your feedback on this. I'm actually thinking about reducing the interface of Permission so that we don't need to implement the getRoles. The idea is to remove the need of maintaining bi-directional association (which simplify a lot in Doctrine).

I can't really find a case where you would like to traverse the permission from the permission to the roles.

@danizord
Copy link
Contributor

👍

@danizord
Copy link
Contributor

This interface is really needed? Since Rbac needs a string, I think you can accept only string and move this interface/casting to ZfcRbac. What do you think?

@bakura10
Copy link
Member Author

Mmmhhh I think it makes sense. It's actually useful to have an interface for that. This allow the rbac to work with any implementation. I still want to keep some lines of code in the rbac component :D

Envoyé de mon iPhone

Le 14 déc. 2013 à 20:24, Daniel Gimenes notifications@github.com a écrit :

This interface is really needed? Since Rbac needs a string, I think you can accept only string and move this interface/casting to ZfcRbac. What do you think?


Reply to this email directly or view it on GitHub.

@bakura10
Copy link
Member Author

I merge as I need that for ZfcRbac. If you have something to say about it, please do it ;-).

bakura10 added a commit that referenced this pull request Dec 14, 2013
Simplify permission interface
@bakura10 bakura10 merged commit 94af1e2 into master Dec 14, 2013
@bakura10 bakura10 deleted the permission branch December 14, 2013 19:42
@aeneasr
Copy link
Contributor

aeneasr commented Dec 15, 2013

Kinda late, but 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants