Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for php 7.4 #60

Merged
merged 1 commit into from Jan 3, 2020
Merged

Add support for php 7.4 #60

merged 1 commit into from Jan 3, 2020

Conversation

snapshotpl
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 3, 2020 •
edited

Coverage Status

Coverage remained the same at 97.315% when pulling 015d3b6 on snapshotpl:patch-1 into 010d4a4 on zf-fr:master.

Ocramius
Ocramius requested changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a lower boundary dependency upgrade before being able to merge this (see failures due to deprecations)

@snapshotpl
Copy link
Contributor Author

Done here #61

@Ocramius
Copy link
Member

Ocramius commented Jan 3, 2020

@snapshotpl merged: can you rebase and we try this again?

@Ocramius Ocramius closed this Jan 3, 2020
@Ocramius
Copy link
Member

Ocramius commented Jan 3, 2020

Wrong button, sorry :)

@Ocramius Ocramius reopened this Jan 3, 2020
@Ocramius Ocramius added this to the 2.1.0 milestone Jan 3, 2020
@Ocramius Ocramius self-assigned this Jan 3, 2020
Ocramius
Ocramius approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ocramius Ocramius merged commit 8f29800 into zf-fr:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snapshotpl @coveralls @Ocramius