DB2 constants are missing when setting up db factory #83
Conversation
| } catch (Throwable $e) { | ||
| if (stristr($e->getMessage(), 'undefined constant')) { | ||
| $this->markTestSkipped(); | ||
| } |
There was a problem hiding this comment.
Example:
But I'm thinking maybe this approach is wrong, better emulate in code the same behavior as older php versions.
There was a problem hiding this comment.
This class can't be even loaded:
The exception is thrown on class construction:
zf1/packages/zend-db/library/Zend/Db.php
Line 270 in 1cfdc03
There was a problem hiding this comment.
I think the only solution here is to assign $_execute_mode default value on the constructor. but no idea about is that backward compatible change or not.
In a lot of cases with PHP8 Type and ValueErrors are thrown instead of warnings emitted. The error handling in tests needed to be modified accordingly. Signed-off-by: Elan Ruusamäe <glen@pld-linux.org> Signed-off-by: Alexander Wozniak <wozniak@oktopos.com>
With php 8.0, the class can't be constructed if constant is missing so the runtime check of extension can never be reached.
falkenhawk
force-pushed
the
db2-setup
branch
from
591a1ab
to
b44b445
Compare
|
In my opinion this will not be necessary as running I am going to close this, thank you for your investigation. |
In a lot of cases with PHP8 Type and ValueErrors are thrown instead of
warnings emitted. The error handling in tests needed to be modified
accordingly.
Changes for this discussion: