This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Extract link url building code #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| $this->urlHelper = $helper; | ||
| return $this; | ||
| } |
There was a problem hiding this comment.
This is a BC break, unfortunately. I think it's likely okay, as it's undocumented functionality, and mainly to serve internal processes, but if anybody was supplying their own helpers previously, this now won't work.
When I merge, I'll re-instate these, but have them throw an exception, indicating what changes they will need to make.
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
Extract link url building code Conflicts: src/Plugin/Hal.php
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optionsparam)These changes prevent to have view helpers, used to generate urls, as dependencies of several classes and keep the url building logic in only one place.