Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Complete migration to enable v3 forwards compatibility #145

Closed
wants to merge 15 commits into from
Closed

Complete migration to enable v3 forwards compatibility #145

wants to merge 15 commits into from

Conversation

weierophinney
Copy link
Member

This patch builds on and supercedes #142. In particular:

  • Adopts full PSR-4 structure, including moving the Module class under the src/ directory. Additionally, the Module class no longer defines a getAutoloaderConfig(), as it's redundant when managed via Composer.
  • Fixes all trigger() calls that were using short-circuiting to use the forwards-compatible triggerEventUntil() with a concrete Event instance.
  • Removes the obsolete PhlyRestfully API documentation.
  • Updates the composer.json to known stable versions of all dependencies:
    • PHP 5.6 becomes the new minimum supported version, and 7.* versions are now allowed.
    • zend-filter and zend-http are now marked as requirements, as they are used in default workflows.
    • zend-json is removed as a dependency, as it is not actually used anywhere in the module.
    • zf-api-problem now has a minimum supported version of 1.2.1.
    • if a component has both v2 and v3 variants, both are allowed.
    • marks the package as a ZF module for usage with zf-component-installer.
  • Updates the README, CONTRIBUTION, CONDUCT, and LICENSE files.

Adam Grabek and others added 15 commits June 8, 2016 03:35
zf3 compatibility + test fixes
9a882e8
composer json cleanup
a611756
composer json repo address
63ea3be
composer json repo address
0497087
@weierophinney
Merge pull request zfcampus#142 from AGmakonts/feature/zf3
0d604d8 
ZF 3.0.0 Compatibility

Conflicts:
	config/module.config.php
	src/Factory/HalViewHelperFactory.php
	test/ChildEntitiesIntegrationTest.php
	test/Extractor/LinkExtractorTest.php
	test/Factory/HalViewHelperFactoryTest.php
@weierophinney
Clear out all test warnings and errors
d9cde9f 
This patch updates the tests so that they now run without errors or
warnings. There are still seven failures, however, which need
addressing.
@weierophinney
Removed obsolete PhlyRestfully API documentation
5d62690
@weierophinney
Update docs to reference both major versions of router classes
f200a35
@weierophinney
Passing tests
7f854d6 
- Updated references to `trigger()` within the `Hal` plugin when they
  use short-circuiting. In those cases, they now call
  `triggerEventUntil()` and pass a new `Event` instance as the second
  argument, using the name, plugin instance, and parameters that were
  previously passed to `trigger()`.
@weierophinney
Implement lowest/locked/latest testing strategy
5b2ced2 
- Allows us to validate v2 and v3 components via CI.
- Fixed CS issues as reported by phpcs.
@weierophinney
Added Code Manifesto, and updated contributing guide
a02bf81
@weierophinney
Mark as a ZF module
f97c37f 
- Marks as a ZF module, and updates the README to reflect this.
- Also updates README to use short array notation.
@weierophinney
Made phpcs and phpunit config files dist files
8aadf97
@weierophinney
Made LICENSE a markdown file
691324c
@weierophinney
Ensure code works against v2
141a373 
`composer.lock` is against v3 components, so ran a `composer update
--prefer-lowest` in order to test against v2 before issuing a pull request. This
uncovered the following:

- `createMock()` does not exist in PHPUnit 4.
- Several assertions were being done against `Zend\Router\RouteMatch`; these
  were updated to vary the class based on zend-mvc version detected.
@weierophinney weierophinney added this to the 1.4.0 milestone Jul 7, 2016
@weierophinney weierophinney self-assigned this Jul 7, 2016
@weierophinney weierophinney mentioned this pull request Jul 7, 2016
Closed
weierophinney added a commit that referenced this pull request Jul 7, 2016
@weierophinney
Added CHANGELOG for #142 and #145
5615c61
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@weierophinney weierophinney

Labels
enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@weierophinney