This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Allow usage with zend-hydrator v3 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
force-pushed
the
feature/zend-hydrator-v3
branch
from
0f95dce
to
e48908d
Compare
zend-hydrator v3 is backwards compatible for consumers, and trivially adoptable via class aliasing for implementors. This patch: - adds 3.0 to the list of allowed version for zend-hydrator, - updates the travis configuration to add the package as a legacy dependency in locked versions prior to PHP 7.2. - moves the test coverage run to PHP 7.1 locked, and excludes the v3 extractor variant from coverage to ensure no parse errors occur
There are two key differences in zend-hydrator v3 we need to accommodate. First, we have added the `HydratorPluginMangerInterface` to zend-hydrator v3. This means that any references to `HydratorPluginManager` when doing type-hinting need to be expanded to allow the more general interface. This patch updates any cases where `HydratorPluginManager` was accepted as an argument to make the argument mixed, and do type-checking internally; cases where `HydratorPluginManager` was returned have been updated to allow either type. Second, the `ExtractionInterface` was updated in v3 to add parameter and return typehints, which affects the `EntityExtractor`. To accommodate the two different signatures, this patch creates two versions of that class, and then adds an autoloading rule that aliases the original name to the correct version.
weierophinney
force-pushed
the
feature/zend-hydrator-v3
branch
from
e48908d
to
f8166bb
Compare
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two key differences in zend-hydrator v3 we need to accommodate.
First, we have added the
HydratorPluginMangerInterfaceto zend-hydrator v3. This means that any references toHydratorPluginManagerwhen doing type-hinting need to be expanded to allow the more general interface. This patch updates any cases whereHydratorPluginManagerwas accepted as an argument to make the argument mixed, and do type-checking internally; cases whereHydratorPluginManagerwas returned have been updated to allow either type.Second, the
ExtractionInterfacewas updated in v3 to add parameter and return typehints, which affects theEntityExtractor. To accommodate the two different signatures, this patch creates two versions of that class, and then adds an autoloading rule that aliases the original name to the correct version.