Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support TensorFlow 2.5 and Python 3.9 #40

Merged
merged 2 commits into from
May 17, 2021
Merged

build: support TensorFlow 2.5 and Python 3.9 #40

merged 2 commits into from
May 17, 2021

Conversation

redeboer
Copy link
Collaborator

Hi @mayou36, it seems that phasespace can safely update to tensorflow 2.5. (There only seem to be problems with test_physics.py, but seems that was already there due to uproot.)

Should anything else be changed?

Alllow installing phasespace with TensorFlow 2.5, which supports
Python 3.9
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, I would tend to remove 3.6, but we can also leave it another round, no damage done.

requirements.txt Outdated Show resolved Hide resolved
Co-authored-by: Jonas Eschle <jonas.eschle@cern.ch>
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and we can address the test failure in #41

@jonas-eschle
Copy link
Contributor

I've added you as a maintainer to the repo, so you do have the rights to merge (and more), is that fine? So feel free to merge

@redeboer
Copy link
Collaborator Author

I've added you as a maintainer to the repo, so you do have the rights to merge (and more), is that fine? So feel free to merge

Thanks! Yeah I'm interested in tackling #39, so that it becomes possible to switch to switch between tensorflow and numpy. I hope to get back to that later this week. Can look into #41 as well then.

@redeboer redeboer merged commit 8a6d5fb into zfit:master May 17, 2021
@redeboer redeboer deleted the tensorflow2.5 branch May 17, 2021 11:49
@jonas-eschle
Copy link
Contributor

Okay that sounds good, feel free to assign yourself to issues.

@redeboer
Copy link
Collaborator Author

@mayou36 Could you create a release for this PR? Then tensorwaves can upgrade to TF 2.5 as well ;)
We can also wait until #46 and it's potential follow-up for numpy, but that could be a bit too much for a version bump.

@jonas-eschle
Copy link
Contributor

jonas-eschle commented May 26, 2021

Jep, just making sure that conda forge goes as well, that has a weird issue currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants