-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: support TensorFlow 2.5 and Python 3.9 #40
Conversation
Alllow installing phasespace with TensorFlow 2.5, which supports Python 3.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good, I would tend to remove 3.6, but we can also leave it another round, no damage done.
Co-authored-by: Jonas Eschle <jonas.eschle@cern.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and we can address the test failure in #41
I've added you as a maintainer to the repo, so you do have the rights to merge (and more), is that fine? So feel free to merge |
Thanks! Yeah I'm interested in tackling #39, so that it becomes possible to switch to switch between tensorflow and numpy. I hope to get back to that later this week. Can look into #41 as well then. |
Okay that sounds good, feel free to assign yourself to issues. |
@mayou36 Could you create a release for this PR? Then tensorwaves can upgrade to TF 2.5 as well ;) |
Jep, just making sure that conda forge goes as well, that has a weird issue currently |
Hi @mayou36, it seems that
phasespace
can safely update to tensorflow 2.5. (There only seem to be problems withtest_physics.py
, but seems that was already there due to uproot.)Should anything else be changed?