Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consistency of init_value. #109

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Fix consistency of init_value. #109

merged 2 commits into from
Feb 18, 2019

Conversation

apuignav
Copy link
Contributor

Closes #108.

PS: I only fixed the "user-facing" kwargs, that is, from Parameter onwards.

@jonas-eschle
Copy link
Contributor

Hm, thinking about it: is just value a better name? The init value comes more from the TF side but is actually "hidden" and rather confusing thinking about it.

just "value"?

@apuignav
Copy link
Contributor Author

Why not? Let me replace all init_value by value.

jonas-eschle
jonas-eschle approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM

@jonas-eschle jonas-eschle merged commit 726ad3a into develop Feb 18, 2019
@jonas-eschle jonas-eschle deleted the initial_value branch April 17, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-eschle jonas-eschle jonas-eschle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistency in kwarg naming in parameters
2 participants
@apuignav @jonas-eschle