KDE Boundary Mirror Logic

[schmitse]

Fixes #

Proposed Changes

• Change the mirror logic of the KDE1DimExact, KDE1DimGrid, KDE1DimFFT, and KDE1DimISJ to use the boundary of the observable space instead of the minimum/maximum of the data. This prevents unwanted ''bumps'' in the pdf when the data falls to zero inside of the observable range and both edges are mirrored.
• Updated the bandwidth description in the docstring of the KDE1DimExact and KDE1DimGrid classes to correctly reflect on the available bandwidth options.

Tests added

• Added tests to the test_kde_funcs.py

Checklist

• change approved
• implementation finished
• correct namespace imported
• tests added
• CHANGELOG updated
• (if new public method/class) docs in rst file updated?

[jonas-eschle]

Hey looks good! I may have missed something in the logic though, but that can be on my side

[jonas-eschle]

That seems fine so far. If you think the implementation is finished, just remove the WIP in the name and request a review. Make sure to tick of the boxes, so you see that everything is done (e.g. add an entry in the CHANGELOG)

[jonas-eschle]

Hey, was just wondering what's the status of this?

[schmitse]

Hi im sorry for the stall. im on it today again.
Fell ill and had work related deadlines coming up.

[schmitse]

In the changelog i have added this:

- KDE datasets are now mirrored around observable space limits

to the bugfixes/small changes section. I cannot git add it though, am i supposed to git add -f the changelog or how does it work?

[schmitse]

Some coverage tests are showing up as failed.
If i interpret the results correctly, for example from coverage/coveralls then the complaint it from the file: zfit/minimizers/minimizers_scipy.py, which i did not modify?
How can i fix this/ Is there a way i can fix this, @jonas-eschle ? :)

[jonas-eschle]

Thanks a lot, this looks good! LGTM