Fix locking order in zfs_zget()

ryao · behlendorf · commit f3ad9cd67ae5 · 2014-04-04T09:12:47.000-07:00
Signed-off-by: Richard Yao &lt;ryao@gentoo.org&gt;
Signed-off-by: Brian Behlendorf &lt;behlendorf1@llnl.gov&gt;
diff --git a/module/zfs/zfs_znode.c b/module/zfs/zfs_znode.c
@@ -922,8 +922,8 @@ zfs_zget(zfs_sb_t *zsb, uint64_t obj_num, znode_t **zpp)
 			*zpp = zp;
 			err = 0;
 		}
-		sa_buf_rele(db, NULL);
 		mutex_exit(&zp->z_lock);
+		sa_buf_rele(db, NULL);
 		ZFS_OBJ_HOLD_EXIT(zsb, obj_num);
 		return (err);
 	}

Original file line number	Diff line number	Diff line change
`@@ -922,8 +922,8 @@ zfs_zget(zfs_sb_t zsb, uint64_t obj_num, znode_t *zpp)`
`922`	`922`	`*zpp = zp;`
`923`	`923`	`err = 0;`
`924`	`924`	`}`
`925`		`- sa_buf_rele(db, NULL);`
`926`	`925`	`mutex_exit(&zp->z_lock);`
	`926`	`+ sa_buf_rele(db, NULL);`
`927`	`927`	`ZFS_OBJ_HOLD_EXIT(zsb, obj_num);`
`928`	`928`	`return (err);`
`929`	`929`	`}`