Fix crash on Samsung Android 10 that call this during parent init.

[Tolriq]

As per title.

[zhanghai]

Can you move the check to the beginning of getProgressTintList() and add a comment saying:

// Samsung Android 10 might call this in super class constructor.

?

Meanwhile, did you confirm if this is the only method that's called in super class constructor? Or, can you confirm that this is enough to fix crash on Samsung devices? I cann't test for myself because I don't own a Samsung device.

[Tolriq]

I can confirm this fix the issue for my users, I can't reproduce as no S10 either and strangely the crash data never reached Play Console so had to ask for users full bug Reports, maybe because it's still a beta build of Android.

Anyway PR updated.

[zhanghai]

Thanks!

[Tolriq]

Any chance to have a 1.3.3 release so I can remove my custom aar ? :)

[zhanghai]

Planning to do this tomorrow.

[zhanghai]

Released in v1.3.3.

[Vibragimov]

@zhanghai @Tolriq This is not a good solution, by code mProgressTintInfo can never be null. Perhaps Samsung is trying to somehow influence through reflection on this field for its OS shell. Look at the ProgressBar source code, it has exactly the same field. I suggest renaming this field so that the UI displays user/library colors instead of Samsung

[Tolriq]

@Vibragimov this is the correct solution and best of all it works, learn about initialization phases in Java when calling super constructors in child constructors :)

Samsung is just trying to get current tintlist during init phase probably because they are using some stupid hacks to implement their dark mode that is a little different than stock Android, but this does not change anything about the fact that the library will have the proper values applied later on for the rendering.

[zhanghai]

I agree with @Tolriq's analysis. It doesn't make sense for Samsung to use reflection, because they can modify any framework code easily. Meanwhile, this fix did fix the issue according to his testing.

[yccheok]

I have an exact same experience.

• The crash is not reported in Google Play Console's ANR & crashes
• The crash is reported in Firebase Crashlytics.

Since, we just install Firebase Crashlytics few weeks back, we are not sure, whether this issue has occured since the early day, or since Samsung Galaxy S10 has performed some software update (around November time frame?!)

We have another high number of crashes (Not related to MaterialRatingBar) these day around December time frame, for Samsung Galaxy S10 - https://issuetracker.google.com/issues/147020028

I was wondering, does Samsung Galaxy S10 introduces some buggy software code update recently, around November time frame?

[yccheok]

I can confirm this fix the issue for my users, I can't reproduce as no S10 either and strangely the crash data never reached Play Console so had to ask for users full bug Reports, maybe because it's still a beta build of Android.

Anyway PR updated.

Hi Tolriq,

Did you see this crash at Samsung Galaxy S10 Android 10 only?

Did you see it in Samsung Galaxy S10 Android 9?

As, I saw you reported this problem in early of Nov.

But, from Internet news, it seems that Samsung only push Android 9 to Android 10 update to users, around December time frame.