Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbelievable slow speed for --siteFile #26

Open
jielab opened this issue Apr 30, 2017 · 4 comments
Open

unbelievable slow speed for --siteFile #26

jielab opened this issue Apr 30, 2017 · 4 comments

Comments

@jielab
Copy link

jielab commented Apr 30, 2017

Please see my comment on #25, it took 43356 seconds to run a regression on 93 SNPs when I used --siteFile. But when i use bcftools first to extract those 93 SNPs to create a new VCF, which takes a minute, then it only took 109 second to run the same analysis

So, i think there is something VERY WRONG with this --siteFile option. Just want to point this out so that others don't run into the same issue.

best regards,
Jie

@zhanxw
Copy link
Owner

zhanxw commented May 1, 2017 via email

@zhanxw
Copy link
Owner

zhanxw commented May 2, 2017

Can you please remind me the number of sites specified by --siteFile option?
Just want to confirm that with you,
as I guess that very large amount of sites slows down the analysis,

Thanks.

@jielab
Copy link
Author

jielab commented May 2, 2017 via email

@zhanxw
Copy link
Owner

zhanxw commented Jun 15, 2017

@jiehuang001 I have optimized --siteFile option to improve speed. However, you may consider using --rangeFile instead.

Since you have a small amount of variants (93 variants) to analyze, I would recommend to use --rangeFile. This option will let RVTESTS utilize the VCF index file, make RVTESTS only read in these variants and analyze them.

When you have lots of variants, --siteFile is more appropriate, as RVTESTS will read in every variant, but only analyze the variants specified in --siteFile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants