Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange behaviour of --numThreads #57

Closed
dkainer opened this issue Mar 7, 2018 · 7 comments
Closed

strange behaviour of --numThreads #57

dkainer opened this issue Mar 7, 2018 · 7 comments

Comments

@dkainer
Copy link

dkainer commented Mar 7, 2018

I am running rvtest on a single node of a cluster. It works, but for some reason if I set --numThreads 16 it runs much slower than when using just --numThreads 1

With --numThreads 1 it completed 95,000 regions for one phenotype in about 140 mins
With --numThreads 16 it completed 95,000 regions for one phenotype in about 570 mins

My command to run rvtest is prefaced with the 'aprun' MPI command so perhaps I need to compile rvtest with some special flags to use the multiple threads properly?

best
David

@zx8754
Copy link

zx8754 commented Sep 11, 2018

@dkainer --numThreads is not in the manuals, is it implemented?

@zhanxw
Copy link
Owner

zhanxw commented Sep 11, 2018

@dkainer numThread helps in certain analysis scenario. It helps most when there are large matrix computations. So 16 threads can be slower than 1 threads in certain cases. What is your use case?

@zhanxw
Copy link
Owner

zhanxw commented Sep 11, 2018

@zx8754 numThreads uses OpenMP. @dkainer it does not use MPI.

@zx8754
Copy link

zx8754 commented Sep 12, 2018

@zhanxw Thank you. Just wanted to point out that I couldn't see that option (--numThreads) in the manuals. But we have --thread N option, is it the same?

@zhanxw
Copy link
Owner

zhanxw commented Dec 6, 2018

The option --thread N is for vcf2kinship, but --numThread N is for rvtest. Sorry for the inconsistency.

@zhanxw zhanxw closed this as completed Dec 6, 2018
@zx8754
Copy link

zx8754 commented Dec 6, 2018

--thread N is documented in the manuals (http://zhanxw.github.io/rvtests/) as below:

When dealing with large input files, it is often preferred to use multiple CPU to speed up calculation using the option --thread N in which N is the number of CPU.

But --numThread N is not in manuals. Could this be added to manuals?

zhanxw added a commit that referenced this issue Dec 6, 2018
@zhanxw
Copy link
Owner

zhanxw commented Dec 6, 2018

Yes, I just did. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants