Support adding extra ssh options on node configurations #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in given how |
|
looks like the errors are only available in garnix and i don't have access 🤔 anyone know how we can see what went wrong? |
|
I think it makes sense to be compatible with |
|
@zhaofengli what do you think about merging this? ❤️ |
|
LGTM, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration of SSH options has been wanted for a while: #90
This patch adds a option on the node configuration to specify SSH options on a per-node basis. Extra SSH options are merged with the pre-defined list on the
ssh_options()function.I'm still not familiar with the colmena codebase, so please correct me if I make any mistakes.
Thank you for your great software and I look forward to feedback.