Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpc-name handling for cpc autostart add #598

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Fix cpc-name handling for cpc autostart add #598

merged 1 commit into from
Apr 28, 2024

Conversation

simon-spinner
Copy link
Contributor

Fix #597

@simon-spinner simon-spinner self-assigned this Apr 19, 2024
@simon-spinner simon-spinner added this to the 1.10.1 milestone Apr 19, 2024
@coveralls
Copy link

coveralls commented Apr 19, 2024 •
edited
Loading

Coverage Status

coverage: 37.115%. remained the same
when pulling e8b76d9 on autostartfix
into 9b95495 on master.

@simon-spinner simon-spinner requested review from EdGue42 and andy-maier and removed request for EdGue42 April 19, 2024 10:24
@simon-spinner @andy-maier
Fix cpc-name handling for cpc autostart add
e8b76d9 
Signed-off-by: Simon Spinner <sspinner@de.ibm.com>
andy-maier
andy-maier approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@andy-maier andy-maier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR and added a change log entry.

Also, I rolled it back into 1.10.1 via PR TBD.

@andy-maier andy-maier modified the milestones: 1.10.1, 1.11.0 Apr 28, 2024
@andy-maier andy-maier mentioned this pull request Apr 28, 2024
Merged
@andy-maier andy-maier merged commit 0351f88 into master Apr 28, 2024
16 checks passed
@andy-maier andy-maier deleted the autostartfix branch April 28, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-maier andy-maier andy-maier approved these changes

@EdGue42 EdGue42 EdGue42 approved these changes

Assignees

@simon-spinner simon-spinner

Labels
rollback done
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Adding partition to CPC autostart list fails with partition not found.
4 participants
@simon-spinner @coveralls @andy-maier @EdGue42