Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git blame gitmoji not showing #220

Open
itspooya opened this issue Mar 16, 2020 · 8 comments
Open

git blame gitmoji not showing #220

itspooya opened this issue Mar 16, 2020 · 8 comments
Labels
203 IDE 2020.3.x 211 IDE 2021.1.x 212 IDE 2021.2+ enhancement

Comments

@itspooya
Copy link

When showing git blame in IDE the gitmoji doesn't get rendered and shows as a text

@zielu
Copy link
Owner

zielu commented Mar 16, 2020

Hi, I only provide completion in commit dialog.

Places where I could add display would be ones from my plugin:

  • status bar blame tooltip
  • blame details popup

Maybe places:

  • inline blame

For Git Log and Annotate provided by IDE it needs more research.

@itspooya
Copy link
Author

itspooya commented Mar 16, 2020

github
Here actually 🎉 shows as text and not as a emoji.
I think its inline blame

  • inline blame

@zielu
Copy link
Owner

zielu commented Mar 16, 2020

Research results:

  • to show them in inline blame implementation would need to switch to com.intellij.openapi.editor.impl.InlayModelImpl#getAfterLineEndElementsForLogicalLine

@zielu
Copy link
Owner

zielu commented Jun 4, 2020

Note to self - try replacing gitmoji text with unicode for example alembic : https://emojipedia.org/emoji/⚗/

See https://blog.jetbrains.com/idea/2020/06/intellij-idea-2020-2-eap2-is-here-with-advanced-exception-stack-trace-analysis-emoji-support-on-linux-and-more/?utm_source=product&utm_medium=link&utm_campaign=TBA for reference

zielu added a commit that referenced this issue Jun 7, 2020
zielu added a commit that referenced this issue Jun 7, 2020
@zielu zielu added 203 IDE 2020.3.x 211 IDE 2021.1.x 212 IDE 2021.2+ and removed 193 201 labels Aug 5, 2021
@zielu
Copy link
Owner

zielu commented Aug 5, 2021

Possible because #268 is done

@scruel
Copy link

scruel commented Nov 3, 2021

Possible because #268 is done
image

No completion in Commit dialog.
IDEA Version: 2021.2.3

@zielu
Copy link
Owner

zielu commented Nov 3, 2021

@scruel not related - missing completion in non-modal dialog is a separate isssue.

I created #355 to track it

@scruel
Copy link

scruel commented Nov 5, 2021

@scruel not related - missing completion in non-modal dialog is a separate isssue.

I created #355 to track it

Ok, I was thought that my issue may same as 'gitmoji not showing', and I noticed you mentioned you provide completion in commit dialog(#220 (comment)), so I post it here, sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
203 IDE 2020.3.x 211 IDE 2021.1.x 212 IDE 2021.2+ enhancement
Projects
None yet
Development

No branches or pull requests

3 participants