Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCNPC_LoadPlayingPlayback file handle is not closed #170

Closed
Naseband opened this issue Nov 23, 2018 · 1 comment
Closed

FCNPC_LoadPlayingPlayback file handle is not closed #170

Naseband opened this issue Nov 23, 2018 · 1 comment

Comments

@Naseband
Copy link

Naseband commented Nov 23, 2018

index = m_vSyncData.size();

Since the file is already stored in memory, shouldn't the file be closed at the end of the function? No reference to it is stored elsewhere so I assume it should be closed.

This is a problem I just experienced with a Race Ghost NPC. I can't replace the recording when a player did a better round time, only after closing the server.

@ziggi
Copy link
Owner

ziggi commented Nov 23, 2018

It seems you are right.

ziggi added a commit that referenced this issue Dec 6, 2018
@ziggi ziggi closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants