Add run test button #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vexu can you review |
Vexu
requested changes
May 31, 2021
| "description": "Additional flags to pass \"zig test\"" | ||
| }, | ||
| "zig.disableProblemMatcherForTest": { | ||
| "type": "bool", |
There was a problem hiding this comment.
Suggested change
| "type": "bool", | |
| "type": "boolean", |
This fixes the Incorrect type. Expected "bool". error when trying to use this setting.
Comment on lines
+31
to
+39
| if ( | ||
| was_newline && | ||
| text.length > i + 4 && | ||
| text[i] === "t" && | ||
| text[i + 1] === "e" && | ||
| text[i + 2] === "s" && | ||
| text[i + 3] === "t" && | ||
| (text[i + 4] === " " || text[i + 4] === "\n") | ||
| ) { |
There was a problem hiding this comment.
This hardly seems like the best solution and breaks easily with badly formatted code:
test"foo" {}
test
"foo" {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "Run test" button above the
testkeyword.zig.testArgsto let you pass additional arguments to testszig.disableProblemMatcherForTestif you don't want the problem matcher to be enabled for testsScreen.Recording.2021-05-23.at.6.03.58.PM.mov
Screenshot incase the video doesn't load:
It would be better to implement this via LSP, but I'm less familiar with that.