Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86_64+macho: pass more behavior tests #18735

Merged
merged 1 commit into from
Feb 6, 2024
Merged

x86_64+macho: pass more behavior tests #18735

merged 1 commit into from
Feb 6, 2024

Conversation

kubkon
Copy link
Member

@kubkon kubkon commented Jan 29, 2024

Fixes #17646

@kubkon kubkon marked this pull request as ready for review January 29, 2024 20:24
@kubkon
Copy link
Member Author

kubkon commented Jan 29, 2024

I've noticed in the previous run that x86_64-macos CI crashed during @bitReverse test. This is interesting since it works fine for me locally but I'm on macOS 13 whereas our CI is running on macOS 11. If it fails again, I'll try reproing it locally on macOS 11, and extract an issue for the future.

@kubkon
Copy link
Member Author

kubkon commented Jan 29, 2024

Just pre-emptively tested if I can repro a crash locally on my x86_64 macOS 11 VM but no dice, everything passed.

@kubkon kubkon mentioned this pull request Jan 31, 2024
Merged
@kubkon kubkon enabled auto-merge (rebase) February 6, 2024 15:25
@kubkon kubkon merged commit 52066bf into master Feb 6, 2024
10 checks passed
@kubkon kubkon deleted the x86_64-macho-tests branch February 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some x86 backend behavior tests are disabled for macho
1 participant
@kubkon