Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Qiumi/Siterwell QM-GS361A-H04 TRV #740

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Adding Qiumi/Siterwell QM-GS361A-H04 TRV #740

merged 1 commit into from
Jan 23, 2021

Conversation

MattWestb
Copy link
Contributor

@MattWestb MattWestb commented Jan 23, 2021

Please close #738 then marge.

Mvh Mattias

@codecov-io
Copy link

Codecov Report

Merging #740 (7eb8a9c) into dev (4f14ef0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #740   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files         176      176           
  Lines        3931     3931           
=======================================
  Hits         3261     3261           
  Misses        670      670           
Impacted Files Coverage Δ
zhaquirks/tuya/valve.py 86.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f14ef0...7eb8a9c. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 505842412

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.956%

Totals Coverage Status
Change from base Build 503912949: 0.0%
Covered Lines: 3261
Relevant Lines: 3931

💛 - Coveralls

@TheJulianJES
Copy link
Collaborator

Since the model seems to always be TS0601, would it make sense to also address this using #735?

@MattWestb
Copy link
Contributor Author

MattWestb commented Jan 23, 2021

Its sound good but i dont knowing how to do that :-((
Edit: Then also for the other devices type in the same quirk so all its being done the same way.

@tube0013
Copy link
Contributor

Since the model seems to always be TS0601, would it make sense to also address this using #735?

I just got a pair of these - https://zigbee.blakadder.com/Moes_AM43-0_45_40-ES-EB.html

I have yet to join them to ZHA where I'll need to figure out a quirk but reading the z2m code they also appear to use the TS0601 model...... so a very different device with same model id.

@Adminiuga
Copy link
Contributor

Fixes #738

@Adminiuga
Copy link
Contributor

Since the model seems to always be TS0601, would it make sense to also address this using #735?

#735 is more of a "proof of concept" I have those two devices in prod, so was able to test it.
The same approach could be use for TS0601, just need to verify there are no other quirks with the exact same model and exact same "endpoint" signature (same input/output clusters, device type, endpoints etc)

If someone with the said valves could test it, then we could create another PR

@MattWestb
Copy link
Contributor Author

MattWestb commented Jan 23, 2021

Tuya is using the same zigbee module (and the same loaded firmware) for switches and all other devices that is talking "tuyanish" and is using it as one communicating channel for tunneling the tuya MCU that sending more or less MQTT commands thru the tunnel.
So only looking on the zigbee module hardware config (module name endpoints and clusters) and not manufacture data its very likela not working.

@Adminiuga
Copy link
Contributor

I just got a pair of these - https://zigbee.blakadder.com/Moes_AM43-0_45_40-ES-EB.html

I wish blakadder was posting the device signature too. Can you join and post the device signature. That's exactly my hesitation, Tuya using the same model for a different device. Need to compare signatures.

@Adminiuga Adminiuga merged commit b1f0f0e into zigpy:dev Jan 23, 2021
@MattWestb MattWestb deleted the patch-1 branch January 23, 2021 18:46
@tube0013
Copy link
Contributor

I just got a pair of these - https://zigbee.blakadder.com/Moes_AM43-0_45_40-ES-EB.html

I wish blakadder was posting the device signature too. Can you join and post the device signature. That's exactly my hesitation, Tuya using the same model for a different device. Need to compare signatures.

added via an issue.... #744

@blakadder
Copy link
Contributor

I just got a pair of these - https://zigbee.blakadder.com/Moes_AM43-0_45_40-ES-EB.html

I wish blakadder was posting the device signature too. Can you join and post the device signature. That's exactly my hesitation, Tuya using the same model for a different device. Need to compare signatures.

I am now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] _TZE200_zivfvd7h TS0601 Qiumi/Siterwell QM-GS361A-H04 TRV
7 participants