Adding new tuya / Moes TRV #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the second type of the _TYST11 tuy /Moes TRV. PR is made for adding them in ZHA for getting the extended functions Moes TRV is having. Not tested by my or some user but #931 is some gave testing the first version but im not 110% that all is working but i think its better then no quirk for the device.
Pull Request Test Coverage Report for Build 958058968
💛 - Coveralls |
|
zigpy/zigpy#653 (comment) updated but picture is coming later then have finding one OK. Edit: Picture added and deleting the TRV from not known model. |
|
Thanks !! |
|
The Becca BRT-100 reporting and also then setting have the setpoint temperature with different multiple as the "normal" Moes TRVs and is one fix for it #981 that is being added for the _TZE200_b6wax7g0 TS0601 variant but if you is getting one _TYST11_b6wax7g0 6wax7g0 it need adding one more device typer in the quirk for fixing it (the extra functions in ZHA is in place) like is being done in the PR linked in the issue. Then the setpoint is sent with one decimal lesser in preposition its also only possible changing it in 1°C and not 0.5°C as with other tuya TRVs. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the second type of the _TYST11 tuy /Moes TRV.
PR is made for adding them in ZHA for getting the extended functions Moes TRV is having.
Not tested by my or some user but #931 is some gave testing the first version but im not 110% that all is working but i think its better then no quirk for the device.