Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop extra_state_attributes property from climate platform #68

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jul 7, 2024

Explicitly set all extra state attributes within state.

ZHA in Core will also filter out None attributes so we can drop the extra filtering logic here.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (26a1316) to head (4d15217).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #68      +/-   ##
==========================================
- Coverage   95.37%   95.36%   -0.01%     
==========================================
  Files          61       61              
  Lines        9341     9327      -14     
==========================================
- Hits         8909     8895      -14     
  Misses        432      432              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly merged commit 0f944b9 into zigpy:dev Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant