Fix light groups not restoring off_brightness
#78
Conversation
| @@ -837,6 +838,8 @@ async def test_zha_group_light_entity( | |||
| ) | |||
|
|
|||
| assert bool(entity.state["on"]) is False | |||
| assert bool(entity.state["off_with_transition"]) is False | |||
There was a problem hiding this comment.
off_with_transition is False is also tested here, but it's False by default anyway, even if not restored.
If we'd want to fully verify that it also restores correctly too, we'd need to modify the test further (or split it out into a separate one), as the code below expects the on cluster command on the OnOff cluster. That doesn't happen if off_with_transition is True though.
Still, the modified test checks that off_with_transition stays False. (and the off_brightness check below is fully correct and would fail if it weren't restored. It would be None before this PR.)
IMO, it's fine like this, but can change if wanted.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #78 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 61 61
Lines 9228 9232 +4
=======================================
+ Hits 8802 8806 +4
Misses 426 426 ☔ View full report in Codecov by Sentry. |
Background info
At the moment, we do not restore light group state at all, which is fine generally.
However,
off_brightnessandoff_with_transitionare not calculated from the member state at the moment.So, we need to restore them to make sure that a group light turned off with a transition still turns on to the correct brightness after a restart (and not completely dim).
(yet to this PR in the "real-world", but it should be fine and is unit-tested at least)
Change
For that reason, this PR restores
off_brightnessandoff_with_transitionfor light groups.The test is also modified to test for the restored
off_brightnessand verifiesoff_with_transitionis stillFalseafter the restore.