Log an error instead of crashing when loading state from a bad CC2531 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users have been using CC2531 adapters that were flashed with Z-Stack 3 *without being erased*. Their TCLK NVRAM entry is too big but Z-Stack seems to still run.
puddly
force-pushed
the
bugfix/backup-inconsistent-cc2531
branch
from
fdfaec9
to
a1436bf
Compare
Codecov Report
@@ Coverage Diff @@
## dev #120 +/- ##
==========================================
- Coverage 98.73% 98.71% -0.03%
==========================================
Files 44 44
Lines 3876 3880 +4
==========================================
+ Hits 3827 3830 +3
- Misses 49 50 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have been using CC2531 adapters that were flashed with Z-Stack 3 without being erased. Their TCLK NVRAM entry is technically too big but Z-Stack seems to still run. The ADDRMGR table, however, is too small. I'm not sure exactly how Z-Stack deals with that situation but it's out of scope for zigpy-znp to automatically do a complete network backup, an NVRAM erase, and a network restore to fix this problem. Instead, an error will be logged on startup.
home-assistant/core#61921