Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit langref.html.in to source control instead of downloading it #2000

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

Techatrix
Copy link
Member

@Techatrix Techatrix commented Aug 16, 2024

#1409 was mistake

#2000 🎉

@nektro
Copy link
Contributor

nektro commented Aug 16, 2024

out of curiosity, why do you feel it was a mistake?

@Techatrix
Copy link
Member Author

out of curiosity, why do you feel it was a mistake?

  • various package distributions needed workarounds because the build phase can't just randomly access the internet
  • the downloaded langref file is not properly cached which means that you can't build ZLS on the next day without internet
  • the downloaded langref file is not pinned by commit hash which hurts reproducibility

ziglang/zig#17895 is the solution.

@Techatrix Techatrix force-pushed the techatrix/no-langref-download branch from c4e4bdd to 2a40ac6 Compare August 16, 2024 19:16
@nektro
Copy link
Contributor

nektro commented Aug 16, 2024

ah makes sense, i mistakenly assumed 17895 was already implemented

@Techatrix Techatrix force-pushed the techatrix/no-langref-download branch from 2a40ac6 to 8f48671 Compare August 22, 2024 15:36
@Techatrix Techatrix merged commit b481aae into master Aug 22, 2024
9 checks passed
@BratishkaErik
Copy link
Contributor

Thank you very much from GURU maintainer!

gentoo-bot pushed a commit to gentoo/guru that referenced this pull request Aug 24, 2024
It's now commited in ZLS repo instead, see
zigtools/zls#2000 .

Signed-off-by: Eric Joldasov <bratishkaerik@landless-city.net>
@Techatrix Techatrix deleted the techatrix/no-langref-download branch August 24, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants